Vim Mode 2022 #439

tombh · 2022-07-26T03:15:39Z

Can I finally get Vim Mode merged?

The keybindings are hardcoded for now, but this is going to change.

Added moveTabLeft and moveTabRight functions, which take a tab ID and try to move the tab as far right or left in the tabOrder as possible. Added previouslyVisitedTab function that switches to the previously selected tab.

with activating input boxes using link hinting.

…m-mode-experimental

In Firefox 63 an old syntax for Marionette commands was deprecated. Updating mostly just meant prepending `WebDriver` to existing commands. This should fix most problems in #232

Vim mode still needs a lot more tests

…to key combinations only working after a certain number of key strokes.

Vim mode still needs a lot more tests

…to key combinations only working after a certain number of key strokes.

This is because Travis' logs had 2 problems. 1. it doesn't capture the entire log output 2. it doesn't show logs when there's a timeout

… event could get interpreted repeatedly. Also some rewrites/improvements of the code. Key mappings can now contain control characters and meta keys with a vim-like notation. There's a hard insert mode, which disables all of browsh's shortcuts and requires 4 hits on ESC to leave. There's a new multiple link opening feature analogous to vimium, that's still incomplete.

@tobimensch

After nearly 4 years I'm finally getting round to shipping all the tremendous hard work of @tobimensch, @j-rewerts and @ed2k. I can't apologise enough that it's taken so long.

laughingbiscuit · 2023-01-01T21:43:38Z

do you want to community to use and test for your fork prior to merge?

martin-braun · 2023-01-19T12:27:30Z

vimium in browsh will be a game changer for me!

jivank · 2023-01-19T16:09:53Z

I was having trouble building this branch with the provided documentation. I assume the repo has a GitHub Action that successfully builds?

tombh · 2023-01-27T13:32:29Z

I would love help with this. The only thing that needs fixing to get this merged is the failing tests.

@jivank The local dev setup docs do indeed need updating. If you're on Linux or similar you can use https://github.com/browsh-org/browsh/blob/master/.github/workflows/main.yml for inspiration.

jivank · 2023-02-03T02:28:22Z

I see in TTY tests:


Error: test/tty/tty_test.go:4:2: package browsh/interfacer/src/browsh is not in GOROOT (/opt/hostedtoolcache/go/1.18.10/x64/src/browsh/interfacer/src/browsh)

This is a similar error I was facing when I was attempting to build it on my local machine.

isaacphi · 2024-09-04T15:41:21Z

@tombh What sort of help do you need with this PR as of now?

tombh · 2024-09-14T13:35:58Z

I never merged it because the tests failed. But considering that I've been giving Browsh so little attention, I guess I could just give up on the tests and make a release with this anyway. If enough people test this PR themselves then I suppose that's enough.

heywoodlh · 2024-09-14T23:08:47Z

All the keyboard shortcuts seem to work for me as expected! Would be nice if the README/website documentation included a list of the shortcuts -- or maybe just a link to

browsh/interfacer/src/browsh/config.go

Lines 78 to 136 in a075246

    
           // Vim commands 
        
           vimKeyMap["normal gg"] = "scrollToTop" 
        
           vimKeyMap["normal G"] = "scrollToBottom" 
        
           vimKeyMap["normal j"] = "scrollDown" 
        
           vimKeyMap["normal k"] = "scrollUp" 
        
           vimKeyMap["normal h"] = "scrollLeft" 
        
           vimKeyMap["normal l"] = "scrollRight" 
        
           vimKeyMap["normal d"] = "scrollHalfPageDown" 
        
           vimKeyMap["normal <C-d>"] = "scrollHalfPageDown" 
        
           vimKeyMap["normal u"] = "scrollHalfPageUp" 
        
           vimKeyMap["normal <C-u>"] = "scrollHalfPageUp" 
        
           vimKeyMap["normal e"] = "editURL" 
        
           vimKeyMap["normal ge"] = "editURL" 
        
           vimKeyMap["normal gE"] = "editURLInNewTab" 
        
           vimKeyMap["normal H"] = "historyBack" 
        
           vimKeyMap["normal L"] = "historyForward" 
        
           vimKeyMap["normal J"] = "prevTab" 
        
           vimKeyMap["normal K"] = "nextTab" 
        
           vimKeyMap["normal r"] = "reload" 
        
           vimKeyMap["normal xx"] = "removeTab" 
        
           vimKeyMap["normal X"] = "restoreTab" 
        
           vimKeyMap["normal t"] = "newTab" 
        
           vimKeyMap["normal T"] = "searchForTab" 
        
           vimKeyMap["normal /"] = "findMode" 
        
           vimKeyMap["normal n"] = "findNext" 
        
           vimKeyMap["normal N"] = "findPrevious" 
        
           vimKeyMap["normal g0"] = "firstTab" 
        
           vimKeyMap["normal g$"] = "lastTab" 
        
           vimKeyMap["normal gu"] = "urlUp" 
        
           vimKeyMap["normal gU"] = "urlRoot" 
        
           vimKeyMap["normal <<"] = "moveTabLeft" 
        
           vimKeyMap["normal >>"] = "moveTabRight" 
        
           vimKeyMap["normal ^"] = "previouslyVisitedTab" 
        
           vimKeyMap["normal m"] = "makeMark" 
        
           vimKeyMap["normal '"] = "gotoMark" 
        
           vimKeyMap["normal i"] = "insertMode" 
        
           vimKeyMap["normal I"] = "insertModeHard" 
        
           vimKeyMap["normal yy"] = "copyURL" 
        
           vimKeyMap["normal p"] = "openClipboardURL" 
        
           vimKeyMap["normal P"] = "openClipboardURLInNewTab" 
        
           vimKeyMap["normal gi"] = "focusFirstTextInput" 
        
           vimKeyMap["normal f"] = "openLinkInCurrentTab" 
        
           vimKeyMap["normal F"] = "openLinkInNewTab" 
        
           vimKeyMap["normal <M-f>"] = "openMultipleLinksInNewTab" 
        
           vimKeyMap["normal yf"] = "copyLinkURL" 
        
           vimKeyMap["normal [["] = "followLinkLabeledPrevious" 
        
           vimKeyMap["normal ]]"] = "followLinkLabeledNext" 
        
           vimKeyMap["normal yt"] = "duplicateTab" 
        
           vimKeyMap["normal v"] = "visualMode" 
        
           vimKeyMap["normal ?"] = "viewHelp" 
        
           vimKeyMap["caret v"] = "visualMode" 
        
           vimKeyMap["caret h"] = "moveCaretLeft" 
        
           vimKeyMap["caret l"] = "moveCaretRight" 
        
           vimKeyMap["caret j"] = "moveCaretDown" 
        
           vimKeyMap["caret k"] = "moveCaretUp" 
        
           vimKeyMap["caret <Enter>"] = "clickAtCaretPosition" 
        
           vimKeyMap["visual c"] = "caretMode" 
        
           vimKeyMap["visual o"] = "swapVisualModeCursorPosition" 
        
           vimKeyMap["visual y"] = "copyVisualModeSelection"

I packaged this PR's commit as a Nix flake for use with the Nix package manager. See below if you are interested in easy installation/testing with Nix.

Flake is here: https://github.com/heywoodlh/flakes/tree/main/browsh

Run the flake with the following command:

nix --extra-experimental-features "nix-command flakes" run "github:heywoodlh/flakes?dir=browsh"

If you do this from Linux, my flake includes Firefox-ESR bundled with it, so it should just work. I've also provided an appimage of my bundled flake -- although, mileage may vary on how well it works as it was very slow for me:

curl -L "https://github.com/heywoodlh/flakes/releases/download/appimages/browsh-$(arch).appimage" -o /tmp/browsh.appimage && chmod +x /tmp/browsh.appimage

/tmp/browsh.appimage

jooaf · 2024-09-16T04:47:23Z

I tested the keyboard shortcuts using the Dockerfile posted here. i then built and tested the docker image from the root of the repo using the following:

docker build -t browsh-vim .
docker run --rm -ti browsh-vim https://hexdocs.pm/gleam_json

for those who are curious, i tested via my fork here
For the most part all of the keybinds seems to work! I did notice that the insert mode keybindings didn't work, but that could just be my terminal. Overall, works as expected thank you so much :)

God-damnit-all · 2024-11-14T17:31:10Z

I never merged it because the tests failed. But considering that I've been giving Browsh so little attention, I guess I could just give up on the tests and make a release with this anyway. If enough people test this PR themselves then I suppose that's enough.

It would be nice to have binaries for the latest version.

tobimensch and others added 30 commits October 7, 2018 14:45

Added new vimium.js with code taken from vimium

bdd0df1

Created overlayVimMode function for displaying vim navigation state

ced1379

gofmt code

6bd4c96

added command for links hints

a78d98b

Set default DISPLAY environment variable for xclipboard functionality

8b35a68

ignore manifest.json backup file

3c8afed

ignore debug log in interfacer/ directory

a04bdac

Fixed typo in comment

0d2dfee

Added sessions permission

9329c9f

Added initial configuration for vim like keybindings.

c40c724

The keybindings are hardcoded for now, but this is going to change.

Added duplicate_tab, restore_tab commands.

f730983

Refactored code using switchToTab and added new features.

b78d896

Added moveTabLeft and moveTabRight functions, which take a tab ID and try to move the tab as far right or left in the tabOrder as possible. Added previouslyVisitedTab function that switches to the previously selected tab.

Added features needed for vim like navigation to the webextension.

052aecd

Added vim like navigation. This is still in an early stage.

4099f51

Instead of adding 1 to Y coord, add 1 to height. This fixes an issues

721b2c8

with activating input boxes using link hinting.

Merge branch 'master' of https://github.com/browsh-org/browsh into vi…

d037732

…m-mode-experimental

Prettified js files

61cd7e1

Fixed typo

ae1df35

Update Go dep to v0.5.0

034d9c4

Newer NVM formats package.lock differently

11f746b

Update FF Marionette commands

d17cb59

In Firefox 63 an old syntax for Marionette commands was deprecated. Updating mostly just meant prepending `WebDriver` to existing commands. This should fix most problems in #232

Update JS and Go deps. Bump Browsh to v1.5.0

bf44f91

Adds Golang clipboard dep

0bda8f1

Refactors Vim code from tty.go into its own file

6f998be

Adds some Vim-specific integration tests

e3568cd

Fixes tests for Vim mode

3beeb76

Vim mode still needs a lot more tests

Vim mode: convert unexported symbols to lowercase

26e9c61

Vim mode: Small updates from PR review

af487ae

Travis CI: Bash timeout for integration tests

15f541c

Fixed bug where keyEvents variable was initialized wrongly. This led …

565e6f4

…to key combinations only working after a certain number of key strokes.

tombh and others added 14 commits June 24, 2019 09:12

Adds some Vim-specific integration tests

eae72e9

Fixes tests for Vim mode

59d2c31

Vim mode still needs a lot more tests

Vim mode: convert unexported symbols to lowercase

8161ea3

Vim mode: Small updates from PR review

ed79db0

Fixed bug where keyEvents variable was initialized wrongly. This led …

7a622b2

…to key combinations only working after a certain number of key strokes.

Travis: upload logs to text host

714cad8

This is because Travis' logs had 2 problems. 1. it doesn't capture the entire log output 2. it doesn't show logs when there's a timeout

Gofmt: some minor capitalisation

b780a79

Added vim feature for editing URL in new tab

9359837

Merge branch 'vim-mode-experimental' into vim-mode-experimental

5dc678e

merge vim_test into tty_test

21081ad

Vim Mode 🥳

5dbb731

After nearly 4 years I'm finally getting round to shipping all the tremendous hard work of @tobimensch, @j-rewerts and @ed2k. I can't apologise enough that it's taken so long.

Merge branch 'master' into vim-mode-2022

ed2a7e0

Linting

889263a

tombh mentioned this pull request Sep 22, 2022

Help with testing vim-mode-experimental #233

Open

tombh mentioned this pull request Nov 28, 2022

Vim mode #31

Open

Merge branch 'master' into vim-mode-2022

a075246

tombh mentioned this pull request Apr 17, 2023

Unable to see normal web-page in plain tty1-tty6 while running latest browsh 1.8.0 on Debian 11 #476

Open

This was referenced Jan 17, 2024

Multi instance - tab-less mode? #507

Open

brow.sh support lalitmee/browse.nvim#23

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vim Mode 2022 #439

Vim Mode 2022 #439

tombh commented Jul 26, 2022

laughingbiscuit commented Jan 1, 2023

martin-braun commented Jan 19, 2023

jivank commented Jan 19, 2023 •

edited

Loading

tombh commented Jan 27, 2023

jivank commented Feb 3, 2023

isaacphi commented Sep 4, 2024

tombh commented Sep 14, 2024

heywoodlh commented Sep 14, 2024

jooaf commented Sep 16, 2024

God-damnit-all commented Nov 14, 2024

Vim Mode 2022 #439

Are you sure you want to change the base?

Vim Mode 2022 #439

Conversation

tombh commented Jul 26, 2022

laughingbiscuit commented Jan 1, 2023

martin-braun commented Jan 19, 2023

jivank commented Jan 19, 2023 • edited Loading

tombh commented Jan 27, 2023

jivank commented Feb 3, 2023

isaacphi commented Sep 4, 2024

tombh commented Sep 14, 2024

heywoodlh commented Sep 14, 2024

jooaf commented Sep 16, 2024

God-damnit-all commented Nov 14, 2024

jivank commented Jan 19, 2023 •

edited

Loading